Fix general settings scroll: DNS Provider focus - #79
Closed
EierKopZA wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Looks like this issue has already been resolved in v1.9.6 (DNS Provider is now focusable and clickable via D-pad). @ProdigyV21 could you confirm if this PR can be closed? |
Contributor
Author
|
Yeah, @ProdigyV21 fixed it right after I made the PR haha. I will close this. |
Owner
|
Yes, just when I was done with the fix I saw the PR xD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\nDNS Provider was unreachable because Skip Profile Selection and DNS rows shared index 12 and general section maxIndex capped at 12.\n\n## Solution\n- Make DNS Provider focused index 13\n- Update content focus bounds for general section from 12 to 13 in both scroll and key handling.\n\n## Validation\n- :app:compilePlayDebugKotlin succeeded.